Update dependencies #24809
Merged
Update dependencies #24809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/updates-jan-27
branch
from
166f08f to
19e03b4
Compare
mosabua
reviewed
Jan 27, 2025
mosabua
approved these changes
Jan 27, 2025
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good .. I am wondering if we need a release notes entry or even a breaking release notes entry since the date handling is now different with the new driver for MySQL
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mosabua it is now correct :) |
Member
Yeah .. I know.. but is that a breaking change? At minimum its a fix of something .. although .. correctly use negative dates.. is kinda super weird and wrong.. |
Contributor
Author
|
@ebyhr : |
ebyhr
approved these changes
Jan 28, 2025
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/updates-jan-27
branch
from
19e03b4 to
45845cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: