Allow Hive metastore caching for Iceberg #24797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
electrum
force-pushed
the
iceberg-cache
branch
3 times, most recently
from
c42fbaf to
4472ac0
Compare
wendigo
force-pushed
the
iceberg-cache
branch
from
4472ac0 to
909180b
Compare
wendigo
approved these changes
Jan 27, 2025
findepi
reviewed
Jan 31, 2025
Comment on lines
-39
to
-45
| Map<String, String> config = ImmutableMap.<String, String>builder() | ||
| .put("hive.metastore.uri", "thrift://localhost:1234") | ||
| .put("hive.metastore-cache-ttl", "5m") | ||
| .put("bootstrap.quiet", "true") | ||
| .buildOrThrow(); | ||
| assertThatThrownBy(() -> createConnector(config)) | ||
| .hasMessageContaining("Hive metastore caching must not be enabled for Iceberg"); |
Member
There was a problem hiding this comment.
if this is now supported, the test should stay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hive metastore caching was originally disallowed to enable Iceberg transaction retry. Without caching, retries were not useful, as each attempt would use the old cached metadata.
AbstractMetastoreTableOperationsnow has a mechanism to explicitly invalidate the cache on refresh.Additional context and related issues
Fixes #13115
Release notes
(x) Release notes are required, with the following suggested text: