Bound and measure BigQuery's Arrow buffer allocations #24777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps bounding the memory allocations
losipiuk
reviewed
Jan 23, 2025
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryArrowBufferAllocator.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 23, 2025
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryArrowAllocatorStats.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Jan 23, 2025
wendigo
force-pushed
the
serafin/bq-allocations
branch
from
ae701dd to
9b61f00
Compare
wendigo
force-pushed
the
serafin/bq-allocations
branch
from
83f1ec0 to
f0afdf2
Compare
mosabua
reviewed
Jan 23, 2025
| } | ||
|
|
||
| @ConfigDescription("Maximum memory allocation allowed for Arrow library") | ||
| @Config("bigquery.arrow-serialization.max-allocation") |
There was a problem hiding this comment.
Dont we want to document this @wendigo ?
There was a problem hiding this comment.
We can but it's not obligatory.
There was a problem hiding this comment.
Seems too deep in the weeds .. lets leave it out until we find someone actually uses this for some benefit
ebyhr
reviewed
Jan 24, 2025
| @Inject | ||
| public BigQueryArrowBufferAllocator(BigQueryArrowConfig config, BigQueryArrowAllocatorStats stats) | ||
| { | ||
| this.maximumAllocation = requireNonNull(config, "config is null").getMaxAllocation().toBytes(); |
There was a problem hiding this comment.
We avoid using requireNonNull for config classes. #13940
| import static io.airlift.configuration.testing.ConfigAssertions.recordDefaults; | ||
| import static io.airlift.units.DataSize.Unit.GIGABYTE; | ||
|
|
||
| class TestBigQueryArrowConfig |
There was a problem hiding this comment.
https://trino.io/docs/current/develop/tests.html#conventions-and-recommendations
Test classes should be defined as package-private and final.
| class TestBigQueryArrowConfig | ||
| { | ||
| @Test | ||
| public void testDefaults() |
There was a problem hiding this comment.
https://trino.io/docs/current/develop/tests.html#conventions-and-recommendations
Test methods should be defined as package-private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: