Fix connection leakage in native Azure filesystem #24773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/switch-to-netty
branch
3 times, most recently
from
dc763a8 to
e92b714
Compare
losipiuk
reviewed
Jan 29, 2025
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureFileSystemFactory.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 29, 2025
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureFileSystemFactory.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 29, 2025
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
This requires some testing. I do not have confidence changed config are fine. Possible those are but I do not have experience with azure.
Contributor
Author
|
@losipiuk I'm testing this internally |
losipiuk
approved these changes
Jan 29, 2025
wendigo
changed the title
This solves an issue with connection leaks that are happening for Azure Storage SDK when OkHttp is used. OkHttp is not actively maintained, which makes the default, Netty implementation, a better choice for the future as it's actively maintained and tested.
wendigo
force-pushed
the
serafin/switch-to-netty
branch
from
e92b714 to
29f89d8
Compare
losipiuk
approved these changes
Jan 30, 2025
Event loop group/maximum number of concurrent requests are already configured so the removed setting was a noop.
Member
|
Release notes entry needed? |
Contributor
Author
|
@mosabua yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue with connection leaks that are happening for Azure Storage SDK
when OkHttp is used. OkHttp is not actively maintained, which makes the default,
Netty implementation, a better choice for the future as it's actively maintained
and tested.
Fixes #24116
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: