Skip to content

Conversation

devozerov
Copy link
Contributor

Description

This PR adds the missing references to several Parquet writer system properties.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 20, 2025
@github-actions github-actions bot added the docs label Jan 20, 2025
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think this is good. However we have duplicate docs in the Delta Lake connector. And parquet_writer_batch_size seems to be NOT supported by that connector .. so the implementation is a mess in the sense that it is NOT the same for all connectors.

Wdyt @electrum should be done here .. maybe we get rid of the docs in the Delta Lake connector and instead add it here. And check that the connectors implement all of them?

Thoughts @findinpath @raunaqmorarka ?

@devozerov stay tuned until we discussed here

@raunaqmorarka
Copy link
Member

Personally I think this is good. However we have duplicate docs in the Delta Lake connector. And parquet_writer_batch_size seems to be NOT supported by that connector .. so the implementation is a mess in the sense that it is NOT the same for all connectors.

Wdyt @electrum should be done here .. maybe we get rid of the docs in the Delta Lake connector and instead add it here. And check that the connectors implement all of them?

Thoughts @findinpath @raunaqmorarka ?

@devozerov stay tuned until we discussed here

I don't think we will get to the point where all data lake connectors have exactly same parquet properties. E.g. writer validation is something that was implemented only for hive connector.

@raunaqmorarka raunaqmorarka merged commit 0448c0d into trinodb:master Jan 23, 2025
8 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants