Verify JVM configuration in Snowflake connector#24717
Merged
hashhar merged 2 commits intotrinodb:masterfrom Feb 7, 2025
Merged
Verify JVM configuration in Snowflake connector#24717hashhar merged 2 commits intotrinodb:masterfrom
hashhar merged 2 commits intotrinodb:masterfrom
Conversation
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
8ef0ea9 to
3be054f
Compare
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
3be054f to
5dc3c32
Compare
mosabua
requested changes
Jan 15, 2025
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
The suggested doc changes are good enough. Ideally however we even create a Requirements section in the connector doc like we have in others.
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
Contributor
|
@mosabua can you fix docs on your end and merge it? |
This will be used in Snowflake connector too in the next commit. Co-authored-by: Mateusz "Serafin" Gajewski <github@wendigo.pl>
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
5dc3c32 to
8a83336
Compare
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
8a83336 to
15f0c59
Compare
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
15f0c59 to
ac70b5c
Compare
Member
Author
|
@mosabua I also updated BigQuery docs to be consistent in style and language to what you proposed here. |
Member
|
Great.. merge away @hashhar |
Snowflake connector uses Arrow which requires additional JVM arguments. The docs were also incorrect, Arrow is always used unconditionally in the Snowflake connector. This additionally makes the docs style and language consistent across both mentions of Arrow related JVM configuration.
hashhar
force-pushed
the
hashhar/snow-arrow-jvm-check
branch
from
ac70b5c to
506b9cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as in BigQuery we need additional JVM args in Snowflake connector since it's using Arrow unconditionally.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: