Fix Exasol flaky tests. Avoid exposing not required ports #24710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
ebyhr
reviewed
Jan 15, 2025
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestingExasolServer.java
Show resolved
Hide resolved
|
Created PR for stress tests as requested: #24714 |
Co-Authored-By: YotillaAntoni <[email protected]>
Co-Authored-By: YotillaAntoni <[email protected]>
ebyhr
force-pushed
the
fix-exasol-flaky-tests
branch
from
3732281 to
91e1610
Compare
ebyhr
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22698.
The CI pipeline runs several tests that boot up an Exasol container, using
testcontainers. An Exasol container by default exposes 4 ports for different services. Docker tries to allocate and map ephemeral ports.Due to an issue in docker, when it fails to allocate a port in can mess up with the process that was using this port (see moby/moby#48132)
The issue only happens when more than one port is exported, so the fix is rather simple: we only export in the container the strictly needed port for JDBC: 8563
Additional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: