Do not persist inf/nan floating point stats in metastore#2471
Merged
findepi merged 1 commit intotrinodb:masterfrom Jan 13, 2020
Merged
Do not persist inf/nan floating point stats in metastore#2471findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
kokosing
approved these changes
Jan 11, 2020
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
Is this something that could be supported in certain version of HMS? Maybe GLUE supports that?
Personally, I don't see a reason why inf values are bad. Other than that it is hard to calculate anything with this.
Member
Author
|
@kokosing there is no advantage from storing max=inf. The only information it carries is that data didn't contain NaN. |
Hive metastore does not accept infinity or NaN values.
Member
Author
|
CI failed -- #2467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hive metastore does not accept infinity or NaN values.