Fix incomplete results from iceberg table_changes function #24709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyangli34
force-pushed
the
jinyang-fix_table_changes
branch
from
c7aa1ab to
d408a3f
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSmallScheduleSplitBatch.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSmallScheduleSplitBatch.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSmallScheduleSplitBatch.java
Outdated
Show resolved
Hide resolved
jinyangli34
force-pushed
the
jinyang-fix_table_changes
branch
from
d408a3f to
b29b9c9
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
jinyangli34
force-pushed
the
jinyang-fix_table_changes
branch
from
b29b9c9 to
c743a90
Compare
raunaqmorarka
force-pushed
the
jinyang-fix_table_changes
branch
2 times, most recently
from
6ede0ca to
d8298cf
Compare
raunaqmorarka
force-pushed
the
jinyang-fix_table_changes
branch
from
d8298cf to
af11339
Compare
raunaqmorarka
approved these changes
Jan 23, 2025
raunaqmorarka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug in
isFinished()could causetable_changesreturn partial data.Additional context and related issues
See unit test
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: