Skip to content

Conversation

@mosabua
Copy link
Member

@mosabua mosabua commented Jan 10, 2025

Description

Look at the two commits separately when reviewing .. second commit is just trivial formatting stuff.

More general questions however is .. why do we even have two metadata tables .. if $entries is just a subset of $all_entries would it make sense to just have one table and just use a where clause or whatever when you want to limit data? Sort of reflecting the question from @raunaqmorarka at #24543 (comment)

But maybe this is just how it works in Iceberg ..

Additional context and related issues

#24543

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua requested review from ebyhr and findinpath January 10, 2025 20:13
@cla-bot cla-bot bot added the cla-signed label Jan 10, 2025
@github-actions github-actions bot added the docs label Jan 10, 2025
@mosabua mosabua requested review from martint and raunaqmorarka and removed request for findinpath January 10, 2025 20:15
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document $all_manifests table as well.

@mosabua mosabua merged commit 963a42c into trinodb:master Jan 12, 2025
3 of 8 checks passed
@mosabua mosabua deleted the allentries branch January 12, 2025 04:22
@github-actions github-actions bot added this to the 469 milestone Jan 12, 2025
@mosabua
Copy link
Member Author

mosabua commented Jan 12, 2025

We should document $all_manifests table as well.

#24690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants