Skip to content

Fix query runners failing to expose local ports #24677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix query runners failing to expose local ports #24677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ng/trino-testing-containers/src/main/java/io/trino/testing/containers/TestContainers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public static String getPathFromClassPathResource(String resourcePath)

public static void exposeFixedPorts(GenericContainer<?> container)
{
checkState(isEnvSet("CONTINUOUS_INTEGRATION"), "" +
checkState(!isEnvSet("CONTINUOUS_INTEGRATION"), "" +
"Exposing fixed ports should not be used in regular test code. This could break parallel test execution. " +
"This method is supposed to be invoked from local development helpers only e.g. QueryRunner.main(), " +
"hence it should never run on CI");
Expand Down
Loading