Skip to content

Ensure visibility of finalSinkMetrics #24667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Ensure visibility of finalSinkMetrics #24667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/trino-main/src/main/java/io/trino/execution/buffer/SpoolingExchangeOutputBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ public class SpoolingExchangeOutputBuffer
private volatile SpoolingOutputBuffers outputBuffers;
// This field is not final to allow releasing the memory retained by the ExchangeSink instance.
// It is modified (assigned to null) when the OutputBuffer is destroyed (either finished or aborted).
// It doesn't have to be declared as volatile as the nullification of this variable doesn't have to be immediately visible to other threads.
// However since the abort can be triggered at any moment of time this variable has to be accessed in a safe way (avoiding "check-then-use").
private ExchangeSink exchangeSink;
private volatile ExchangeSink exchangeSink;
private Optional<Metrics> finalSinkMetrics;
private final Supplier<LocalMemoryContext> memoryContextSupplier;

Expand Down
Loading