Fix SetDigest, BingTile, Kdb Tree, Color types (de)serialization in client protocol #24612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/client-types
branch
from
2ba8c29 to
b5528c5
Compare
This makes it explicit in regard to the ClientStandardTypes list of types
These types have a custom serialization logic utilizing JsonCreator/JsonProperty annotations.
wendigo
force-pushed
the
serafin/client-types
branch
from
b5528c5 to
7fda4b0
Compare
wendigo
changed the title
wendigo
changed the title
martint
reviewed
Jan 7, 2025
| public static final String ARRAY = "array"; | ||
| public static final String MAP = "map"; | ||
| public static final String JSON = "json"; | ||
| public static final String JSON_2016 = "json2016"; |
There was a problem hiding this comment.
This is an internal type, not meant to be exposed to clients
There was a problem hiding this comment.
It's not exposed. It's here so the files are the same (server/client ones) for easier comparison
| public static final String GEOMETRY = "Geometry"; | ||
| public static final String SPHERICAL_GEOGRAPHY = "SphericalGeography"; | ||
| public static final String BING_TILE = "BingTile"; | ||
| public static final String KDB_TREE = "KdbTree"; |
There was a problem hiding this comment.
Same with this one. This type is just there to support some types of geospatial joins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: