Skip to content

Derive aws sdk retry count from request count #24606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Derive aws sdk retry count from request count #24606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions lib/trino-hdfs/src/main/java/io/trino/hdfs/s3/AwsSdkClientCoreStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public final class AwsSdkClientCoreStats
{
private final CounterStat awsRequestCount = new CounterStat();
private final CounterStat awsRetryCount = new CounterStat();
private final CounterStat awsHttpClientRetryCount = new CounterStat();
private final CounterStat awsThrottleExceptions = new CounterStat();
private final TimeStat awsRequestTime = new TimeStat(MILLISECONDS);
private final TimeStat awsClientExecuteTime = new TimeStat(MILLISECONDS);
Expand All @@ -66,6 +67,13 @@ public CounterStat getAwsRetryCount()
return awsRetryCount;
}

@Managed
@Nested
public CounterStat getAwsHttpClientRetryCount()
{
return awsHttpClientRetryCount;
}

@Managed
@Nested
public CounterStat getAwsThrottleExceptions()
Expand Down Expand Up @@ -134,12 +142,16 @@ public void collectMetrics(Request<?> request, Response<?> response)

Number requestCounts = timingInfo.getCounter(RequestCount.name());
if (requestCounts != null) {
stats.awsRequestCount.update(requestCounts.longValue());
long count = requestCounts.longValue();
stats.awsRequestCount.update(count);
if (count > 1) {
stats.awsRetryCount.update(count - 1);
}
}

Number retryCounts = timingInfo.getCounter(HttpClientRetryCount.name());
if (retryCounts != null) {
stats.awsRetryCount.update(retryCounts.longValue());
Number httpClientRetryCounts = timingInfo.getCounter(HttpClientRetryCount.name());
if (httpClientRetryCounts != null) {
stats.awsHttpClientRetryCount.update(httpClientRetryCounts.longValue());
}

Number throttleExceptions = timingInfo.getCounter(ThrottleException.name());
Expand Down
20 changes: 16 additions & 4 deletions ...rino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/v1/AwsSdkClientCoreStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public final class AwsSdkClientCoreStats
{
private final CounterStat awsRequestCount = new CounterStat();
private final CounterStat awsRetryCount = new CounterStat();
private final CounterStat awsHttpClientRetryCount = new CounterStat();
private final CounterStat awsThrottleExceptions = new CounterStat();
private final TimeStat awsRequestTime = new TimeStat(MILLISECONDS);
private final TimeStat awsClientExecuteTime = new TimeStat(MILLISECONDS);
Expand All @@ -66,6 +67,13 @@ public CounterStat getAwsRetryCount()
return awsRetryCount;
}

@Managed
@Nested
public CounterStat getAwsHttpClientRetryCount()
{
return awsHttpClientRetryCount;
}

@Managed
@Nested
public CounterStat getAwsThrottleExceptions()
Expand Down Expand Up @@ -134,12 +142,16 @@ public void collectMetrics(Request<?> request, Response<?> response)

Number requestCounts = timingInfo.getCounter(RequestCount.name());
if (requestCounts != null) {
stats.awsRequestCount.update(requestCounts.longValue());
long count = requestCounts.longValue();
stats.awsRequestCount.update(count);
if (count > 1) {
stats.awsRetryCount.update(count - 1);
}
}

Number retryCounts = timingInfo.getCounter(HttpClientRetryCount.name());
if (retryCounts != null) {
stats.awsRetryCount.update(retryCounts.longValue());
Number httpClientRetryCounts = timingInfo.getCounter(HttpClientRetryCount.name());
if (httpClientRetryCounts != null) {
stats.awsHttpClientRetryCount.update(httpClientRetryCounts.longValue());
}

Number throttleExceptions = timingInfo.getCounter(ThrottleException.name());
Expand Down
Loading