Skip to content

Deprecate CALL rollback_to_snapshot and add corresponding table procedure in Iceberg #24580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Deprecate CALL rollback_to_snapshot and add corresponding table procedure in Iceberg #24580

merged 1 commit into from
Jan 7, 2025

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Dec 26, 2024 •
edited
Loading

Release notes

## Iceberg
* Add `rollback_to_snapshot` table procedure. The existing `system.rollback_to_snapshot` procedure is 
  deprecated and will be removed in a future release. ({issue}`24580`)

@cla-bot cla-bot bot added the cla-signed label Dec 26, 2024
@github-actions github-actions bot added docs iceberg Iceberg connector labels Dec 26, 2024
findinpath
findinpath reviewed Dec 30, 2024
View reviewed changes
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/procedure/RollbackToSnapshotProcedure.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of a larger endeavor ?
If there are other follow-ups maybe it is worth creating a epic issue to track what else will be done.

@ebyhr ebyhr force-pushed the ebi/iceberg-rollback-to-snapshot branch from f439e87 to f07e642 Compare January 7, 2025 01:03
@ebyhr ebyhr requested a review from raunaqmorarka January 7, 2025 01:03
@ebyhr ebyhr merged commit 5319c2c into trinodb:master Jan 7, 2025
53 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-rollback-to-snapshot branch January 7, 2025 13:03
@github-actions github-actions bot added this to the 469 milestone Jan 7, 2025
@mosabua mosabua mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

+1 more reviewer

@findinpath findinpath findinpath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed docs iceberg Iceberg connector

Milestone

469

Development

Successfully merging this pull request may close these issues.

3 participants

@ebyhr @raunaqmorarka @findinpath