Skip to content

Run Iceberg concurrent tests multiple times #24548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Run Iceberg concurrent tests multiple times #24548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 39 additions & 20 deletions ...trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergLocalConcurrentWrites.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import io.trino.testing.MaterializedResult;
import io.trino.testing.QueryRunner;
import io.trino.testing.sql.TestTable;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.RepeatedTest;
import org.junit.jupiter.api.TestInstance;

import java.util.List;
Expand Down Expand Up @@ -52,7 +52,8 @@ protected QueryRunner createQueryRunner()
return IcebergQueryRunner.builder().build();
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentInserts()
throws Exception
{
Expand Down Expand Up @@ -101,7 +102,8 @@ private void testConcurrentInserts(boolean partitioned)
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentInsertsSelectingFromTheSameTable()
throws Exception
{
Expand Down Expand Up @@ -148,7 +150,8 @@ private void testConcurrentInsertsSelectingFromTheSameTable(boolean partitioned)
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentInsertsSelectingFromTheSameVersionedTable()
throws Exception
{
Expand Down Expand Up @@ -197,7 +200,8 @@ private void testConcurrentInsertsSelectingFromTheSameVersionedTable(boolean par
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentDelete()
throws Exception
{
Expand Down Expand Up @@ -238,7 +242,8 @@ void testConcurrentDelete()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentDeleteFromTheSamePartition()
throws Exception
{
Expand Down Expand Up @@ -273,7 +278,8 @@ void testConcurrentDeleteFromTheSamePartition()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentTruncate()
throws Exception
{
Expand Down Expand Up @@ -308,7 +314,8 @@ void testConcurrentTruncate()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentTruncateAndInserts()
throws Exception
{
Expand Down Expand Up @@ -349,7 +356,8 @@ void testConcurrentTruncateAndInserts()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentNonOverlappingUpdate()
throws Exception
{
Expand Down Expand Up @@ -390,7 +398,8 @@ void testConcurrentNonOverlappingUpdate()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentOverlappingUpdate()
throws Exception
{
Expand Down Expand Up @@ -455,7 +464,8 @@ private void testConcurrentOverlappingUpdate(boolean partitioned)
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentNonOverlappingUpdateOnNestedPartition()
throws Exception
{
Expand Down Expand Up @@ -502,7 +512,8 @@ void testConcurrentNonOverlappingUpdateOnNestedPartition()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentDeleteAndInserts()
throws Exception
{
Expand Down Expand Up @@ -579,7 +590,8 @@ void testConcurrentDeleteAndInserts()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateAndInserts()
throws Exception
{
Expand Down Expand Up @@ -657,7 +669,8 @@ void testConcurrentUpdateAndInserts()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentMergeAndInserts()
throws Exception
{
Expand Down Expand Up @@ -737,7 +750,8 @@ void testConcurrentMergeAndInserts()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentDeleteAndDeletePushdownAndInsert()
throws Exception
{
Expand Down Expand Up @@ -781,7 +795,8 @@ void testConcurrentDeleteAndDeletePushdownAndInsert()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateWithPartitionTransformation()
throws Exception
{
Expand Down Expand Up @@ -824,7 +839,8 @@ void testConcurrentUpdateWithPartitionTransformation()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateWithNestedPartitionTransformation()
throws Exception
{
Expand Down Expand Up @@ -867,7 +883,8 @@ void testConcurrentUpdateWithNestedPartitionTransformation()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateWithMultiplePartitionTransformation()
throws Exception
{
Expand Down Expand Up @@ -924,7 +941,8 @@ void testConcurrentUpdateWithMultiplePartitionTransformation()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateWithOverlappingPartitionTransformation()
throws Exception
{
Expand Down Expand Up @@ -985,7 +1003,8 @@ void testConcurrentUpdateWithOverlappingPartitionTransformation()
}
}

@Test
// Repeat test with invocationCount for better test coverage, since the tested aspect is inherently non-deterministic.
@RepeatedTest(3)
void testConcurrentUpdateWithEnforcedAndUnenforcedPartitions()
throws Exception
{
Expand Down
Loading