Include deletion vector when filtering active add entries in Delta #24524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Hi @ebyhr, read through the end-2-end state reconstruction code. With this PR changes overall state construction LGTM.
ebyhr
requested review from
findinpath,
raunaqmorarka and
wendigo
and removed request for
wendigo
wendigo
approved these changes
Dec 19, 2024
pajaks
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@vkorukanti told us that we are missing deletion vector id in the key. The corresponding delta-kernel code:
Hopefully, solves #22972. This PR doesn't contain tests because the entire steps to reproduce is still unclear.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.