Use data size for delta metadata cache#24432
Merged
raunaqmorarka merged 2 commits intomasterfrom Dec 13, 2024
Merged
Conversation
2d4fe4e to
b36c81c
Compare
ebyhr
approved these changes
Dec 13, 2024
b36c81c to
2ea68bc
Compare
Reduces chances of coordinator OOM by accounting for retained size of objects in delta metadata cache
TTL can be higher because the cached metadata is immutable and the space occupied by it in memory is accounted for
2ea68bc to
80b9a63
Compare
Member
|
Just in general and with regards to the release notes.. this is a breaking change since you are removing a property. |
Member
Author
Yes, it is a breaking change intentionally. We need users who were overriding the previous property to make a decision about how much coordinator memory they want to consume for the metadata cache. The old way could have potentially unbounded memory usage due to large transaction log jsons. |
Member
|
Great.. please check my reworded commit message in the release notes PR .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces chances of coordinator OOM by accounting
for retained size of objects in delta metadata cache.
TTL can be higher because the cached metadata is immutable
and the space occupied by it in memory is accounted for.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: