Deprecate iceberg.materialized-views.storage-schema property#24398
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Dec 10, 2024
Merged
Conversation
The recommended way of handling storage tables is to have `iceberg.materialized-views.hide-storage-table` set to true, and not use `iceberg.materialized-views.storage-schema`. `iceberg.materialized-views.hide-storage-table` is already deprecated. We should stick with the default behavior of hiding the storage table from end users, and not having to set a schema for storing them.
anusudarsan
force-pushed
the
anu/deprecate-storage-schema-iceberg-mv
branch
from
e2d2c37 to
38ea2a0
Compare
ebyhr
approved these changes
Dec 9, 2024
alexjo2144
reviewed
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recommended way of handling storage tables is to have
iceberg.materialized-views.hide-storage-tableset to true, and not useiceberg.materialized-views.storage-schema.iceberg.materialized-views.hide-storage-tableis already deprecated. We should stick with the default behavior of hiding the storage table from end users, and not having to set a schema for storing them.Release notes