Use executor service for iceberg scan planning system tables#24396
Merged
Conversation
tbaeg
force-pushed
the
system-table-threads
branch
from
32cf9ea to
1dc5b27
Compare
tbaeg
force-pushed
the
system-table-threads
branch
3 times, most recently
from
faa7f35 to
6ab0aea
Compare
tbaeg
changed the title
tbaeg
changed the title
tbaeg
force-pushed
the
system-table-threads
branch
from
6ab0aea to
5d8cafd
Compare
tbaeg
force-pushed
the
system-table-threads
branch
from
5d8cafd to
30df813
Compare
raunaqmorarka
approved these changes
Dec 12, 2024
ebyhr
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use existing executor service for scans on system tables in iceberg to prevent excessive cpu/heap usage.
This is especially prevalent for system with high core count.
The existing code was using the threadpool of iceberg library for system tables and another threadpool provided by Trino for normal table scans.
Additional context and related issues
https://trinodb.slack.com/archives/CJ6UC075E/p1733411820070579
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: