Add all_manifests metadata table to Iceberg
#24330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Dec 3, 2024
findinpath
reviewed
Dec 4, 2024
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.iceberg; |
Contributor
There was a problem hiding this comment.
Is the documenation for this table on https://trino.io/docs/current/connector/iceberg.html#metadata-tables coming as a follow-up ?
cc @mosabua
Member
Member
There was a problem hiding this comment.
But yes .. it would have been better to do the docs as part of this PR so the release notes can link to docs and users get a feature with docs at the same time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
all_manifestsmetadata table provides data for the current snapshot as well as all snapshots.This table will be helpful when we support rewriting manifests in the future.
Added the null handling just in case though I couldn't find how to get NULL from
contains_nanfield.https://iceberg.apache.org/docs/latest/spark-queries/#all-manifests
Docs PR can be handled in different PR. We may want to separate a section for
all_metadata tables.Release notes