Delete the oldest tracked version metadata files after commit in Iceberg #24306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
changed the title
ebyhr
reviewed
Nov 29, 2024
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
7hong
force-pushed
the
master
branch
3 times, most recently
from
de4e401 to
1ce6ba0
Compare
ebyhr
reviewed
Dec 1, 2024
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
7hong
force-pushed
the
master
branch
2 times, most recently
from
0b6a250 to
d5bc9ae
Compare
ebyhr
force-pushed
the
master
branch
3 times, most recently
from
74b52b4 to
447af1b
Compare
ebyhr
previously approved these changes
Dec 1, 2024
ebyhr
reviewed
Dec 1, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergV2.java
Outdated
Show resolved
Hide resolved
7hong
force-pushed
the
dev
branch
8 times, most recently
from
ab952ce to
6deed07
Compare
|
Any more progress on this? I'd love to get this change. |
7hong
force-pushed
the
dev
branch
5 times, most recently
from
7ede4d6 to
b94871a
Compare
7hong
force-pushed
the
dev
branch
3 times, most recently
from
4eb13af to
e9757d7
Compare
|
@ebyhr I added test in |
|
/test-with-secrets sha=b8f9227fcc6a6fd89aeac3cc5602aadbc01ca369 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12474870064 |
ebyhr
force-pushed
the
dev
branch
2 times, most recently
from
8801c61 to
873f3e9
Compare
|
/test-with-secrets sha=873f3e9c4aa460c5095724224838069813408ad8 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12476325378 |
|
/test-with-secrets sha=782ffcf711fa69a86fd68d504a7362fe11e60fa4 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12476584429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the iceberg table, the xxx-metadata.json file is generated each time commit is executed. In the iceberg table, we can automatically clean the previous metadata file through configuration.
write.metadata.delete-after-commit.enabled = truewrite.metadata.previous-versions-max = 10However, the metadata file is not automatically cleaned in trino. A large number of metadata.json files are left on the hdfs.
Different from #20863 ，I have followed the configurations in iceberg (write.metadata.delete-after-commit.enabled and write.metadata.previous-version-max ). Instead of adding a new configuration, this keeps it compatible with iceberg.
Relates to #14128
Release notes