Add protocol to the SPI module-info #24303
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Nov 28, 2024
| @@ -31,6 +31,7 @@ | |||
| exports io.trino.spi.memory; | |||
| exports io.trino.spi.metrics; | |||
| exports io.trino.spi.predicate; | |||
| exports io.trino.spi.protocol; | |||
There was a problem hiding this comment.
Why does the SPI have a protocol package? Unless it’s for plugin implementations meant to extend the protocol, there shouldn’t be any dependencies between the protocol and SPI - I know there might be some legacy stuff around type serialization, but we should try to clean that up over time.
There was a problem hiding this comment.
This is for spooling manager SPI. We can move it to some other package if this is the wrong name for it.
There was a problem hiding this comment.
(SpoolingManager is pluggable)
There was a problem hiding this comment.
Yeah, let’s rename the package. That’s doesn’t seem like the right name.
There was a problem hiding this comment.
What do you propose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: