Skip to content

Faker and BigQuery cleanups #24276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Faker and BigQuery cleanups #24276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a242b
Revert "Increase allowed timeouts for BigQuery service"
hashhar Nov 18, 2024
9004d0a
Fix invalid scope in trino-faker pom
hashhar Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryRpcConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public BigQueryRpcConfig setMaxRpcPerChannel(int maxRpcPerChannel)
}

@Min(0)
@Max(1024)
@Max(16)
public int getRetries()
{
return retries;
Expand All @@ -126,7 +126,7 @@ public BigQueryRpcConfig setRetries(int maxRetries)
}

@MinDuration("0s")
@MaxDuration("30m")
@MaxDuration("1m")
public Duration getTimeout()
{
return timeout;
Expand All @@ -141,7 +141,7 @@ public BigQueryRpcConfig setTimeout(Duration timeout)
}

@MinDuration("0s")
@MaxDuration("1m")
@MaxDuration("30s")
public Duration getRetryDelay()
{
return retryDelay;
Expand Down
36 changes: 18 additions & 18 deletions plugin/trino-faker/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,30 @@
<scope>provided</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log-manager</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>units</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-client</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>junit-extensions</artifactId>
Expand Down Expand Up @@ -162,23 +180,5 @@
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log</artifactId>
<scope>test-jar</scope>
</dependency>

<dependency>
<groupId>io.airlift</groupId>
<artifactId>log-manager</artifactId>
<scope>test-jar</scope>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-client</artifactId>
<scope>test-jar</scope>
</dependency>
</dependencies>
</project>