Remove iceberg.rest-catalog.parent-namespace config property
#24269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-rest-parent-workspace
branch
2 times, most recently
from
7ea6639 to
6ebba64
Compare
mayankvadariya
approved these changes
Nov 27, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java
Outdated
Show resolved
Hide resolved
The property was added for supporting Unity catalog. They changed the behavior to respect warehouse property in unitycatalog/unitycatalog#324.
ebyhr
force-pushed
the
ebi/iceberg-rest-parent-workspace
branch
from
6ebba64 to
f76e3c3
Compare
raunaqmorarka
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The property was added for supporting Unity catalog.
They changed the behavior to respect
warehouseproperty in unitycatalog/unitycatalog#324 and the property is no longer needed.Release notes