Fix failure when setting NULL in UPDATE statement in JDBC-based connectors #24244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
force-pushed
the
24204_pg
branch
from
38a5bbc to
d78fb22
Compare
ebyhr
reviewed
Nov 25, 2024
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
changed the title
chenjian2664
force-pushed
the
24204_pg
branch
from
d78fb22 to
9059706
Compare
chenjian2664
force-pushed
the
24204_pg
branch
2 times, most recently
from
459a2bd to
01c5a65
Compare
chenjian2664
force-pushed
the
24204_pg
branch
2 times, most recently
from
1569338 to
bdfaed3
Compare
chenjian2664
commented
Nov 27, 2024
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
|
/test-with-secrets sha=bdfaed330c96e2b7c16a7609c8ab88ad361c1b61 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12060467495 |
chenjian2664
force-pushed
the
24204_pg
branch
2 times, most recently
from
12a5ea8 to
f839265
Compare
ebyhr
reviewed
Dec 13, 2024
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
24204_pg
branch
13 times, most recently
from
8d7512d to
723e52b
Compare
chenjian2664
force-pushed
the
24204_pg
branch
2 times, most recently
from
4c20ba4 to
39f601e
Compare
|
@ebyhr the test addressed, would you mind to have a look |
|
@ebyhr Gentle reminder, the pr is ready to review |
ebyhr
reviewed
Dec 20, 2024
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
24204_pg
branch
from
b85384f to
b68056c
Compare
chenjian2664
force-pushed
the
24204_pg
branch
2 times, most recently
from
36dbcfb to
3975c83
Compare
hashhar
approved these changes
Jan 15, 2025
ebyhr
reviewed
Jan 16, 2025
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
24204_pg
branch
from
3975c83 to
36da83f
Compare
…ctors Co-Authored-By: Yuya Ebihara <[email protected]>
chenjian2664
force-pushed
the
24204_pg
branch
from
36da83f to
d611162
Compare
ebyhr
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #24204
Release notes