Merged
Conversation
ebyhr
commented
Oct 30, 2024
ebyhr
force-pushed
the
ebi/iceberg-1.7.0-rc
branch
3 times, most recently
from
7199a21 to
be4d217
Compare
ebyhr
force-pushed
the
ebi/iceberg-1.7.0-rc
branch
from
be4d217 to
410540a
Compare
wendigo
approved these changes
Nov 10, 2024
ksobolew
reviewed
Dec 27, 2024
| partitionValue.decimalValue(), | ||
| createDecimalType(decimalType.precision(), decimalType.scale())); | ||
| // TODO https://github.com/trinodb/trino/issues/19753 Support Iceberg timestamp types with nanosecond precision | ||
| case TIMESTAMP_NANO: |
Contributor
There was a problem hiding this comment.
FYI: there's also io.trino.plugin.iceberg.catalog.glue.GlueIcebergUtil#toGlueTypeStringLossy. It has a default clause, which makes the switch not subject to exhaustivity checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.