Remove incorrect check in QueryBuilder#238
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 15, 2019
Merged
Conversation
It's engine's duty not to create range-based `TupleDomain`s for non-orderable types, therefore the check was redundant. Even for a non-orderable type, engine can create an equality-based (enumerated) `TupleDomain`, so the check was not correct.
findepi
force-pushed
the
findepi/master/remove-redundant-check-in-querybuilder-ab524c
branch
from
57f47aa to
54f14b0
Compare
kokosing
approved these changes
Feb 15, 2019
sopel39
approved these changes
Feb 15, 2019
findepi
deleted the
findepi/master/remove-redundant-check-in-querybuilder-ab524c
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's engine's duty not to create range-based
TupleDomains fornon-orderable types, therefore the check was redundant. Even for a
non-orderable type, engine can create an equality-based (enumerated)
TupleDomain, so the check was not correct.