Support DateTime64 in ClickHouse

[ssheikin]

Description

Additional context and related issues

• More predicate pushdown in ClickHouse connector #7100
• Add support for Datetime64 type in ClickHouse connector #10537
• Add support for DateTime64 in ClickHouse #15040

PRs:

• Running branch for Clickhouse pushdowns #23460
• Fix insert to Clickhouse TimestampWithTimeZone #23785
• Update supported clickhouse versions #24515
• Support DateTime64 in ClickHouse #23788
• Improve DateTime64 pushdown to ClickHouse #23789
• Pushdown Timestamp Extraction functions to ClickHouse #23802

ClickHouse docs:

• https://clickhouse.com/docs/en/sql-reference/data-types/datetime
• https://clickhouse.com/docs/en/sql-reference/data-types/datetime64

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Section
* Support DateTime64 in ClickHouse. ({issue}`issuenumber`)

[Praveen2112]

I need to check with the test code

[Praveen2112]

Isn't this check a bit redundant ?

[ssheikin]

I think it may be useful. In Trino MAX_PRECISION = 12 for TimestampWithTimeZoneType.

[ssheikin]

@Praveen2112 comments are addressed. PTAL.

[ssheikin]

@Praveen2112 comments are addressed, PTAL.

[Praveen2112]

Can this be merged with TIMESTAMP_SECONDS -

[ssheikin]

Assuming you are asking about these cases:

        if (type == TIMESTAMP_SECONDS) {
            return WriteMapping.longMapping("DateTime", timestampSecondsWriteFunction(getClickHouseServerVersion(session)));
        }
        if (type instanceof TimestampType timestampType) {
            return timestampWriteMapping(timestampType);
        }

They could be merged, but TimestampType returns native type as DateTime64(%s), whereas TIMESTAMP_SECONDS -> DateTime without precision.
The default processing may be changed later via additional property.
As this change is invasive let's reconsider it in separate PR if needed.

[ssheikin]

I see that this moment may never come, so will address in this PR.

[Praveen2112]

We need to handle the min and max value like we handle for seconds right ?

[Praveen2112]

Can we add multiple precision for testUnsupportedTimestamp

[github-actions]

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

[github-actions]

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.