Support s3 cross region bucket access #23652
Closed
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusudarsan
reviewed
Oct 4, 2024
| @@ -115,6 +115,7 @@ public static RetryStrategy getRetryStrategy(RetryMode retryMode) | |||
| private RetryMode retryMode = RetryMode.LEGACY; | |||
| private int maxErrorRetries = 10; | |||
| private boolean supportsExclusiveCreate = true; | |||
| private boolean crossRegionAccessEnabled; | |||
There was a problem hiding this comment.
please add documentation in file-system-s3.md
electrum
reviewed
Oct 4, 2024
| awsEndpoint.ifPresent(s3::endpointOverride); | ||
| if (isCrossRegionAccessEnabled && awsEndpoint.isEmpty()) { | ||
| if (awsRegion.isEmpty()) { | ||
| s3.region(Region.US_EAST_1); |
There was a problem hiding this comment.
Why hard-code to a specific region?
If we remove this code, what happens?
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support s3 cross region bucket access
Additional context and related issues
In the legacy filesystem, this is not configurable but when region and endpoint is not set, us-east-1 will be set (which is also the default when setting aws-global) and cross region bucket access is allowed. The sdk v2 does not have this option earlier and now it supports it.
With this PR, we want to make this is configurable, while also set region and cross region access when no region nor endpoint is defined. When region is defined, and endpoint is not, then we will look at this config to determine if cross region access is allowed.
We need this config to guard that in certain regions, no cross region access is allowed, while in some other regions, cross region access can be done
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: