Fix config property name to match semantics #23585
Open
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
requested review from
wweiss-starburst
and removed request for
walterddr
wendigo
approved these changes
Sep 26, 2024
krvikash
reviewed
Sep 26, 2024
| } | ||
|
|
||
| @Config("max-tasks-waiting-for-node-per-stage") | ||
| @ConfigDescription("Maximum possible number of tasks waiting for node allocation per stage before scheduling of new tasks for stage is paused") | ||
| public QueryManagerConfig setMaxTasksWaitingForNodePerStage(int maxTasksWaitingForNodePerStage) |
There was a problem hiding this comment.
Do we need to add @LegacyConfig for existing user? or User will have to change the configuration?
There was a problem hiding this comment.
I could add that - not sure if should given property name is just plain wrong - but maybe the way to go still.
krvikash
approved these changes
Sep 26, 2024
losipiuk
force-pushed
the
lukaszos/fix-config-property-name-to-match-semantics-615c79
branch
from
3dc0069
to
faf694b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: