Merged
Conversation
wendigo
force-pushed
the
serafin/spooling-encryption
branch
2 times, most recently
from
9e00aa9 to
7f389d1
Compare
wendigo
force-pushed
the
serafin/spooling-encryption
branch
2 times, most recently
from
ecff7d7 to
ce337ae
Compare
losipiuk
reviewed
Sep 25, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...pooling-filesystem/src/main/java/io/trino/spooling/filesystem/FileSystemSpoolingManager.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
Member
There was a problem hiding this comment.
I am not a big fan of this one. This is fine in tests but it changes the semantics of interface significantly by putting constraints on EncryptionKey passed to new*File methods,
it looks it would be trivial to just inline the logic in openInputStream, createOutputStream and directLocation and not use EncryptionEnforcingFileSystem at all
Contributor
Author
There was a problem hiding this comment.
I actually did it before but changed that in the meantime.
losipiuk
reviewed
Sep 25, 2024
Member
There was a problem hiding this comment.
can be a followup but I think that SpoolingManager should throw TrinoException. Not IOException. Then you can provide nice error code which explains what is going on.
Contributor
Author
There was a problem hiding this comment.
Yeah, that area can be improved
losipiuk
reviewed
Sep 25, 2024
...ooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/AzureSSEHeaders.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...ooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/AzureSSEHeaders.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...ooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/AzureSSEHeaders.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...ooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/AzureSSEHeaders.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...o-spooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/HeaderUtils.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 25, 2024
...no-spooling-filesystem/src/main/java/io/trino/spooling/filesystem/encryption/SSEHeaders.java
Outdated
Show resolved
Hide resolved
In comparison to Minio it supports SSE-C without the need to configure TLS to secure connection.
wendigo
force-pushed
the
serafin/spooling-encryption
branch
from
ce337ae to
1130731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: