Skip to content

Use upper bounded wildcard to read and delete cookie#23539

Merged
wendigo merged 1 commit intotrinodb:masterfrom
krvikash:krvikash/OAuthWebUiCookie-change
Sep 24, 2024
Merged

Use upper bounded wildcard to read and delete cookie#23539
wendigo merged 1 commit intotrinodb:masterfrom
krvikash:krvikash/OAuthWebUiCookie-change

Conversation

@krvikash
Copy link
Contributor

@krvikash krvikash commented Sep 24, 2024

Description

Use upper bounded wildcard to read and delete cookie. It will help to use same api to read and delete NewCookie.

Copy link
Contributor

@ksobolew ksobolew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also OAuthIdTokenCookie, AFAICT

@krvikash krvikash force-pushed the krvikash/OAuthWebUiCookie-change branch from 60225b1 to 2ed839f Compare September 24, 2024 07:12
@krvikash krvikash changed the title Use upper bounded wildcard to read and delete cookie in OAuthWebUiCookie Use upper bounded wildcard to read and delete cookie Sep 24, 2024
@krvikash
Copy link
Contributor Author

Thanks @ksobolew for the review. Added OAuthIdTokenCookie as well.

@wendigo wendigo merged commit 9f9576f into trinodb:master Sep 24, 2024
@krvikash krvikash deleted the krvikash/OAuthWebUiCookie-change branch September 24, 2024 17:51
@github-actions github-actions bot added this to the 459 milestone Sep 24, 2024
@mosabua
Copy link
Member

mosabua commented Sep 25, 2024

I assume no release note entry needed @wendigo and @krvikash .. note please use template or label to indicate on each PR.

@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

@mosabua no, this is helper util :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants