Add support for server-side encryption with customer key to S3#23533
Merged
Add support for server-side encryption with customer key to S3#23533
Conversation
wendigo
force-pushed
the
serafin/filesystem-encryption
branch
from
0d5f7f9 to
c363fe9
Compare
wendigo
force-pushed
the
serafin/filesystem-encryption
branch
from
c363fe9 to
c13f7c0
Compare
electrum
reviewed
Sep 23, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3InputFile.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3InputFile.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/filesystem-encryption
branch
from
c13f7c0 to
6628ffc
Compare
Contributor
Author
|
AC @electrum |
electrum
approved these changes
Sep 23, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3InputFile.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SseCUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SseCUtils.java
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/AbstractTestS3FileSystem.java
Show resolved
Hide resolved
...o-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionEnforcingFileSystem.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/encryption/EncryptionKey.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/filesystem-encryption
branch
from
6628ffc to
200cbf6
Compare
findinpath
reviewed
Sep 24, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3SseCUtils.java
Show resolved
Hide resolved
findinpath
reviewed
Sep 24, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Show resolved
Hide resolved
findinpath
reviewed
Sep 24, 2024
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/AbstractTestS3FileSystem.java
Show resolved
Hide resolved
Member
|
No RN @wendigo .. right? Kinda feels like we might want some.. |
Contributor
Author
|
@mosabua No, this is used only for spooling |
Member
|
Thanks @wendigo |
marcinsbd
reviewed
Sep 27, 2024
| this.cannedAcl = getCannedAcl(context.cannedAcl()); | ||
| this.key = requireNonNull(key, "key is null"); | ||
|
|
||
| verify(key.isEmpty() || sseType == S3SseType.NONE, "Encryption key cannot be used with sse configuration"); |
Contributor
There was a problem hiding this comment.
this is the only one place when you touch sseType config variable
As I understand, this line states that if we provide key the sseType needs to be set to S3SseType.NONE to allow further processing? is this correct ?
imho, judging by the rest of the code in this PR, the PR seems to be irrelevant to the settings of sseType config variable at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: