Generate a run annotation when test environment fails to start#23515
Merged
wendigo merged 1 commit intotrinodb:masterfrom Sep 20, 2024
Merged
Generate a run annotation when test environment fails to start#23515wendigo merged 1 commit intotrinodb:masterfrom
wendigo merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
reviewed
Sep 20, 2024
...no-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/Environment.java
Outdated
Show resolved
Hide resolved
When product tests fail, they produce an report, which is used to generate GitHub Actions annotations so it's easier to know the failure cause, without having to browse the failed job logs. Generate a similar annotation when the test environment fails to start, which is a common failure cause. The original error is still produced, so it can be looked up in logs, for anyone that's used to doing it.
nineinchnick
force-pushed
the
ptl-annotations
branch
from
8b57816 to
1634de3
Compare
wendigo
approved these changes
Sep 20, 2024
Member
Author
|
CI failure doesn't look related. @wendigo can you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When product tests fail, they produce an report, which is used to generate GitHub Actions annotations so it's easier to know the failure cause, without having to browse the failed job logs. Generate a similar annotation when the test environment fails to start, which is a common failure cause.
The original error is still produced, so it can be looked up in logs, for anyone that's used to doing it.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: