Skip to content

Fix incorrect assertions used#23509

Merged
wendigo merged 3 commits intomasterfrom
serafin/fix-cli
Sep 19, 2024
Merged

Fix incorrect assertions used#23509
wendigo merged 3 commits intomasterfrom
serafin/fix-cli

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 19, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm .. thank you so much

@wendigo wendigo merged commit f2f9d9e into master Sep 19, 2024
@wendigo wendigo deleted the serafin/fix-cli branch September 19, 2024 20:18
@github-actions github-actions bot added this to the 459 milestone Sep 19, 2024
@metadaddy
Copy link
Member

Thanks for following up on this, folks, and thanks for the help, @wendigo!

@wendigo
Copy link
Contributor Author

wendigo commented Sep 20, 2024

@metadaddy no worries :) Logical merge conflicts like that happen on the time! Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants