Fix annotating CI run when product tests fail#23499
Merged
wendigo merged 1 commit intotrinodb:masterfrom Sep 19, 2024
Merged
Conversation
The product tests job test step should have an ID used to check if it failed, so its test reports can be processed and annotations can be generated.
raunaqmorarka
approved these changes
Sep 19, 2024
wendigo
approved these changes
Sep 19, 2024
Contributor
|
@nineinchnick there is no annotation here |
Member
Author
|
I think this is because the environment failed to start, and it didn't even run any tests. If This should not block us from merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The product tests job test step should have an ID used to check if it failed, so its test reports can be processed and annotations can be generated.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: