Allow generating presigned URIs for S3 and GCS #23342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
changed the title
wendigo
force-pushed
the
serafin/s3-presigned-uri
branch
4 times, most recently
from
537954f
to
1c64e87
Compare
wendigo
changed the title
|
This will be useful for spooling :) |
losipiuk
reviewed
Sep 10, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/TrinoFileSystem.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 10, 2024
lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 10, 2024
lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 10, 2024
lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Sep 10, 2024
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystem.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/s3-presigned-uri
branch
from
1c64e87
to
daf26e5
Compare
wendigo
force-pushed
the
serafin/s3-presigned-uri
branch
from
daf26e5
to
020b297
Compare
electrum
approved these changes
Sep 11, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemLoader.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/s3-presigned-uri
branch
from
020b297
to
a2685f7
Compare
|
@electrum I can't get azure to work. I will ask someone from Microsoft for help and move forward without it |
|
Release notes needed? |
|
@colebow no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: