Reduce filesystem accesses in delta connector #23329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
electrum
approved these changes
Sep 8, 2024
lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemModule.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemModule.java
Outdated
Show resolved
Hide resolved
Use a tracing wrapper on external FS to track any FS calls made by cache implementations. Removed redudant tracking of external FS calls from cache implementations. Updated tests for tracing FS calls to be closer to reality.
raunaqmorarka
force-pushed
the
delta-dv-fs
branch
from
6582784
to
17463bb
Compare
|
Test failure related to #23080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid multiple filesystem accesses for reading deletion vector.
Avoid multiple small read requests on delta checkpoints.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: