Reduce hot loop in DirectExchangeClient #23320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Sep 10, 2024
| @@ -389,6 +398,7 @@ private synchronized void clientFinished(HttpPageBufferClient client) | |||
| { | |||
| requireNonNull(client, "client is null"); | |||
| if (completedClients.add(client)) { | |||
| runningClients.remove(client); | |||
There was a problem hiding this comment.
nit: you could add check state that client was actually removed. Similar to adding clients to queuedClients
|
To help with a release note, what is the user-facing impact of this? Improving performance or fixing query failure, and when might it happen? cc @sopel39 |
|
@colebow I would say we probably can skip release note for this one. It's impact is hard to estimate, but requires large scale to see the difference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
8b6983a has changed improved hot loop on list
On the top of this, we could improve more by keeping running clients. So we don't have to loop through
allClientsevery time.I faced a case DirectExchangeClient had about 10k allClients. Looping on it every schedule caused lock contention.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( x ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: