Skip to content

Debug startup of trino containers without timeout #23283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Praveen2112 merged 1 commit into from
Sep 6, 2024
Merged

Debug startup of trino containers without timeout #23283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...oduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/EnvironmentUp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.io.OutputStream;
import java.io.PrintStream;
import java.nio.file.Path;
import java.time.Duration;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -111,6 +112,7 @@ public static class Execution
private final DockerContainer.OutputMode outputMode;
private final Map<String, String> extraOptions;
private final PrintStream printStream;
private final boolean debug;

@Inject
public Execution(EnvironmentFactory environmentFactory, EnvironmentConfig environmentConfig, EnvironmentOptions options, EnvironmentUpOptions environmentUpOptions, PrintStream printStream)
Expand All @@ -124,6 +126,7 @@ public Execution(EnvironmentFactory environmentFactory, EnvironmentConfig enviro
this.logsDirBase = requireNonNull(environmentUpOptions.logsDirBase, "environmentUpOptions.logsDirBase is null");
this.extraOptions = ImmutableMap.copyOf(requireNonNull(environmentUpOptions.extraOptions, "environmentUpOptions.extraOptions is null"));
this.printStream = requireNonNull(printStream, "printStream is null");
this.debug = options.debug;
}

@Override
Expand All @@ -139,6 +142,14 @@ public Integer call()
builder.removeContainers(container -> isTrinoContainer(container.getLogicalName()));
}

if (debug) {
builder.configureContainers(container -> {
if (isTrinoContainer(container.getLogicalName())) {
container.withStartupTimeout(Duration.ofMillis(Integer.MAX_VALUE));
}
});
}

log.info("Creating environment '%s' with configuration %s and options %s", environment, environmentConfig, extraOptions);
Environment environment = builder.build(getStandardListeners(environmentLogPath));
environment.start();
Expand Down