Skip to content

Remove deprecated DecimalConversions.realToShortDecimal #23275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Sep 4, 2024
Merged

Remove deprecated DecimalConversions.realToShortDecimal #23275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/trino-spi/src/main/java/io/trino/spi/type/DecimalConversions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import static io.trino.spi.type.Int128Math.rescale;
import static java.lang.Double.parseDouble;
import static java.lang.Float.floatToRawIntBits;
import static java.lang.Float.intBitsToFloat;
import static java.lang.Float.parseFloat;
import static java.lang.String.format;
import static java.math.RoundingMode.HALF_UP;
Expand Down Expand Up @@ -122,16 +121,6 @@ private static Int128 internalDoubleToLongDecimal(double value, long precision,
}
}

/**
* @deprecated Use {@link #realToShortDecimal(float, long, long)} instead
*/
@Deprecated(forRemoval = true)
public static long realToShortDecimal(long value, long precision, long scale)
{
float floatValue = intBitsToFloat(intScale(value));
return realToShortDecimal(floatValue, precision, scale);
}

public static long realToShortDecimal(float value, long precision, long scale)
{
// TODO: implement specialized version for short decimals
Expand Down