Skip to content

Random non-functional cleanups #23263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 2 commits into from
Sep 4, 2024
Merged

Random non-functional cleanups #23263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb8eae
Fix redundantly named variable
hashhar Sep 3, 2024
aa516d6
Remove obsolete issue link
hashhar Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSinkProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public class HivePageSinkProvider
private final HiveSessionProperties hiveSessionProperties;
private final HiveWriterStats hiveWriterStats;
private final long perTransactionMetastoreCacheMaximumSize;
private final boolean temporaryStagingDirectoryDirectoryEnabled;
private final boolean temporaryStagingDirectoryEnabled;
private final String temporaryStagingDirectoryPath;

@Inject
Expand Down Expand Up @@ -111,7 +111,7 @@ public HivePageSinkProvider(
this.hiveSessionProperties = requireNonNull(hiveSessionProperties, "hiveSessionProperties is null");
this.hiveWriterStats = requireNonNull(hiveWriterStats, "hiveWriterStats is null");
this.perTransactionMetastoreCacheMaximumSize = config.getPerTransactionMetastoreCacheMaximumSize();
this.temporaryStagingDirectoryDirectoryEnabled = config.isTemporaryStagingDirectoryEnabled();
this.temporaryStagingDirectoryEnabled = config.isTemporaryStagingDirectoryEnabled();
this.temporaryStagingDirectoryPath = config.getTemporaryStagingDirectoryPath();
}

Expand Down Expand Up @@ -182,7 +182,7 @@ private HivePageSink createPageSink(HiveWritableTableHandle handle, boolean isCr
eventClient,
hiveSessionProperties,
hiveWriterStats,
temporaryStagingDirectoryDirectoryEnabled,
temporaryStagingDirectoryEnabled,
temporaryStagingDirectoryPath);

return new HivePageSink(
Expand Down
2 changes: 1 addition & 1 deletion testing/trino-product-tests/src/main/java/io/trino/tests/product/PrestoTemptoPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public List<Class<? extends SuiteModuleProvider>> getSuiteModules()
HiveVersionProvider.ModuleProvider.class);
}

@SuppressWarnings("rawtypes") // TODO https://github.com/trinodb/trino/issues/9904
@SuppressWarnings("rawtypes")
@Override
public List<Class<? extends TableManager>> getTableManagers()
{
Expand Down