Fix incorrect results when writing deletion vectors in Delta Lake#23231
Merged
Fix incorrect results when writing deletion vectors in Delta Lake#23231
Conversation
ebyhr
force-pushed
the
ebi/delta-deletion-vectors-correctness
branch
from
5eb9e07 to
e1cd4ba
Compare
raunaqmorarka
approved these changes
Sep 2, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeSink.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Can we add a test that fails for this case deterministically ?
I don't get why this failure was flaky
Member
Author
|
The test is still flaky. Probably, Databricks/Delta Lake suspects deletion vectors is used even for rewriting all rows. |
ebyhr
force-pushed
the
ebi/delta-deletion-vectors-correctness
branch
from
e1cd4ba to
ff6fcb0
Compare
findinpath
reviewed
Sep 2, 2024
...t-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDeleteCompatibility.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-deletion-vectors-correctness
branch
from
570ea53 to
513a53a
Compare
ebyhr
force-pushed
the
ebi/delta-deletion-vectors-correctness
branch
from
513a53a to
6b47720
Compare
Member
Author
|
Pushed a new commit to fix correctness issue when rewriting all rows. |
raunaqmorarka
approved these changes
Sep 18, 2024
| long rowCount = parquetMetadata.getBlocks().stream().map(BlockMetadata::rowCount).mapToLong(Long::longValue).sum(); | ||
| RoaringBitmapArray rowsRetained = new RoaringBitmapArray(); | ||
| rowsRetained.addRange(0, rowCount); | ||
| rowsRetained.addRange(0, rowCount - 1); |
Member
There was a problem hiding this comment.
Do we have a test which detects this issue ?
Member
Author
There was a problem hiding this comment.
The following line throws an exception without this change:
assertThat(getEntriesFromJson(3, tableLocation + "/_delta_log", FILE_SYSTEM).orElseThrow().get(1).getRemove().deletionVector().orElseThrow())
.isEqualTo(deletionVector);(Not ideal test, but I assume it's enough)
findinpath
reviewed
Sep 18, 2024
| long rowCount = parquetMetadata.getBlocks().stream().map(BlockMetadata::rowCount).mapToLong(Long::longValue).sum(); | ||
| RoaringBitmapArray rowsRetained = new RoaringBitmapArray(); | ||
| rowsRetained.addRange(0, rowCount); | ||
| rowsRetained.addRange(0, rowCount - 1); |
Contributor
There was a problem hiding this comment.
What was happening as a consequence of having a too long range before?
Member
findinpath
reviewed
Sep 18, 2024
| { | ||
| String sourceRelativePath = relativePath(rootTableLocation.toString(), sourcePath); | ||
| DeltaLakeMergeResult result = new DeltaLakeMergeResult(deletion.partitionValues(), Optional.of(sourceRelativePath), Optional.empty()); | ||
| DeletionVectorEntry deletionVector = deletionVectors.get(sourceRelativePath); |
Contributor
There was a problem hiding this comment.
follow-up: do we need any special handling for deletion vectors from shallowly cloned tables?
findinpath
reviewed
Sep 18, 2024
| long deletionTimestamp, | ||
| boolean dataChange) | ||
| boolean dataChange, | ||
| Optional<DeletionVectorEntry> deletionVector) |
Contributor
There was a problem hiding this comment.
Where does delta lake need deletionVector in the remove file entries?
Contributor
There was a problem hiding this comment.
Just noticed
Optional<DeletionVectorEntry> deletionVector = Optional.empty();
if (deletionVectorsEnabled) {
deletionVector = Optional.ofNullable(remove.getRow("deletionVector"))
.map(row -> parseDeletionVectorFromParquet(session, row, removeDeletionVectorType.orElseThrow()));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23229
Release notes