Skip to content

Update pinot to 1.2.0#23210

Merged
wendigo merged 1 commit intotrinodb:masterfrom
elonazoulay:serafin/pinot-1.2-with-fixes
Aug 31, 2024
Merged

Update pinot to 1.2.0#23210
wendigo merged 1 commit intotrinodb:masterfrom
elonazoulay:serafin/pinot-1.2-with-fixes

Conversation

@elonazoulay
Copy link
Copy Markdown
Member

Description

Update to pinot 1.2.0

Attempted to push to #23143 but could not find the branch. I manually copied @wendigo's first commit.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 31, 2024
@elonazoulay elonazoulay requested review from ebyhr and wendigo August 31, 2024 12:02
Comment thread plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotClient.java Outdated
Comment thread plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotModule.java Outdated
Copy link
Copy Markdown
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add testing against Pinot 1.2 server as a follow-up

Co-authored-by: Elon Azoulay <elon.azoulay@gmail.com>
@wendigo wendigo force-pushed the serafin/pinot-1.2-with-fixes branch from c8aaf93 to 129dbab Compare August 31, 2024 20:55
@wendigo
Copy link
Copy Markdown
Contributor

wendigo commented Aug 31, 2024

I've squashed two commits into single one before merging

@wendigo wendigo merged commit 0226642 into trinodb:master Aug 31, 2024
@github-actions github-actions bot added this to the 456 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants