Fix regression on disabled HTTP/2 negotiation#23190
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Aug 30, 2024
Merged
Conversation
oneonestar
force-pushed
the
star/remove_dead_code
branch
from
3b86c5a to
e3cc46c
Compare
wendigo
reviewed
Aug 30, 2024
Contributor
wendigo
left a comment
wendigo
left a comment
There was a problem hiding this comment.
Actually it's not supported nor tested. It seems that this should be applied but lost in the meantime
oneonestar
force-pushed
the
star/remove_dead_code
branch
from
e3cc46c to
52a4050
Compare
oneonestar
changed the title
Member
Author
|
Ok. Updated to restore the behavior. |
wendigo
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove dead code in OkHttpUtil.I assume this isn't needed since we now support http2 (#21793).Fix regression on disabled HTTP/2 negotiation.
Additional context and related issues
Added by:
0de7236
Usage was gone in (unintentionally?):
05bcba6#diff-2514cab429f6ab30764fd3c34e7318b2085145a670a206283497208b9547de40L617
Release notes
(looks like the
- [x]syntax triggers a task list)