Fix calculate error of bytesToReadInPage in AlluxioInputHelper.putBuffer#23175
Fix calculate error of bytesToReadInPage in AlluxioInputHelper.putBuffer#23175raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: wangdongwei.
|
04a4efa to
878ba94
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
878ba94 to
8be0562
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: wangdongwei.
|
8be0562 to
e676bee
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
#23172 for this issue |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
6822274 to
18d2654
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
18d2654 to
8110868
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
8110868 to
19bb5b3
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@raunaqmorarka ptal |
19bb5b3 to
b8b060c
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
b8b060c to
eb16dd3
Compare
b45f6a9 to
a71ccda
Compare
|
@jkylling @raunaqmorarka take a review please |
jkylling
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
I'm curious how did you discover this bug?
...io/src/test/java/io/trino/filesystem/alluxio/TestAlluxioCacheFileSystemAccessOperations.java
Outdated
Show resolved
Hide resolved
...io/src/test/java/io/trino/filesystem/alluxio/TestAlluxioCacheFileSystemAccessOperations.java
Outdated
Show resolved
Hide resolved
...io/src/test/java/io/trino/filesystem/alluxio/TestAlluxioCacheFileSystemAccessOperations.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
left a comment
There was a problem hiding this comment.
@coderwf please address the above comments.
Other than that, PR lgtm
@jkylling I used paimon for trino to query the data stored on HDFS service, the data amount is about 60GB and contains lots of small files , so query latency fluctuates greatly when HDFS is unstable, then I enabled the Alluxio filesystem cache which store data on local ssd, but the performance is not very good, so I suspected it is caused by the low cache hit rate, through the opentelemetry service I found that there are indeed a lot of small data queries still requesting hdfs. |
a71ccda to
1db728d
Compare
Description
Additional context and related issues
Fixes #23172
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: