Add support for S3 conditional writes #23149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extracted from #23145 |
nineinchnick
approved these changes
Aug 28, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/s3-exclusive-write-support
branch
2 times, most recently
from
bf9d7e6
to
1a8551c
Compare
nineinchnick
approved these changes
Aug 28, 2024
|
@nineinchnick i've added exclusive create to local filesystem too. Now all the implementations support it which is a powerful primitive to have :) |
wendigo
force-pushed
the
serafin/s3-exclusive-write-support
branch
3 times, most recently
from
cb84ec5
to
e098dae
Compare
anusudarsan
approved these changes
Aug 28, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemConfig.java
Show resolved
Hide resolved
This allows implementing exclusive write that will ensure that the next putObject won't override existing file.
wendigo
force-pushed
the
serafin/s3-exclusive-write-support
branch
from
e098dae
to
63041ff
Compare
losipiuk
reviewed
Aug 29, 2024
losipiuk
reviewed
Aug 29, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputStream.java
Show resolved
Hide resolved
losipiuk
reviewed
Aug 29, 2024
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3OutputFile.java
Show resolved
Hide resolved
losipiuk
reviewed
Aug 29, 2024
lib/trino-filesystem/src/main/java/io/trino/filesystem/local/LocalOutputFile.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Aug 29, 2024
wendigo
force-pushed
the
serafin/s3-exclusive-write-support
branch
from
63041ff
to
356d345
Compare
It added conditional write support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementing exclusive write that will ensure that the next putObject won't override existing file.
This makes all three major cloud storage filesystem implementations support
createExclusiveDescription
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: