Skip coordinator in getWorkerMemoryInfo if not included in task processing #23079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
added
the
no-release-notes
raunaqmorarka
approved these changes
Aug 20, 2024
|
CI: #23080 |
losipiuk
added a commit
to losipiuk/trino
that referenced
this pull request
Aug 26, 2024
The change to filter out coordinator from output of ClusterMemoryManager::getWorkerMemoryInfo (trinodb#23079) was beneficial for how ExponentialGrowthPartitionMemoryEstimator behaves if coordinator is differently sized than workers. Yet it introduced regression as same method was used in BinPackingNodeAllocatorService and as a result COORDINATOR_ONLY tasks could not be scheduled at all if node-scheduler.include-coordinator was set to false. Unfortunately we had node-scheduler.include-coordinator set to true in all the tests so it was not catch by automation. This commit adds a regression test too.
losipiuk
added a commit
that referenced
this pull request
Aug 26, 2024
The change to filter out coordinator from output of ClusterMemoryManager::getWorkerMemoryInfo (#23079) was beneficial for how ExponentialGrowthPartitionMemoryEstimator behaves if coordinator is differently sized than workers. Yet it introduced regression as same method was used in BinPackingNodeAllocatorService and as a result COORDINATOR_ONLY tasks could not be scheduled at all if node-scheduler.include-coordinator was set to false. Unfortunately we had node-scheduler.include-coordinator set to true in all the tests so it was not catch by automation. This commit adds a regression test too.
Joelg96
pushed a commit
to Joelg96/trino
that referenced
this pull request
Aug 26, 2024
The change to filter out coordinator from output of ClusterMemoryManager::getWorkerMemoryInfo (trinodb#23079) was beneficial for how ExponentialGrowthPartitionMemoryEstimator behaves if coordinator is differently sized than workers. Yet it introduced regression as same method was used in BinPackingNodeAllocatorService and as a result COORDINATOR_ONLY tasks could not be scheduled at all if node-scheduler.include-coordinator was set to false. Unfortunately we had node-scheduler.include-coordinator set to true in all the tests so it was not catch by automation. This commit adds a regression test too.
mneethiraj
pushed a commit
to mneethiraj/trino
that referenced
this pull request
Sep 2, 2024
The change to filter out coordinator from output of ClusterMemoryManager::getWorkerMemoryInfo (trinodb#23079) was beneficial for how ExponentialGrowthPartitionMemoryEstimator behaves if coordinator is differently sized than workers. Yet it introduced regression as same method was used in BinPackingNodeAllocatorService and as a result COORDINATOR_ONLY tasks could not be scheduled at all if node-scheduler.include-coordinator was set to false. Unfortunately we had node-scheduler.include-coordinator set to true in all the tests so it was not catch by automation. This commit adds a regression test too.
jeschkies
pushed a commit
to jeschkies/trino
that referenced
this pull request
Sep 10, 2024
The change to filter out coordinator from output of ClusterMemoryManager::getWorkerMemoryInfo (trinodb#23079) was beneficial for how ExponentialGrowthPartitionMemoryEstimator behaves if coordinator is differently sized than workers. Yet it introduced regression as same method was used in BinPackingNodeAllocatorService and as a result COORDINATOR_ONLY tasks could not be scheduled at all if node-scheduler.include-coordinator was set to false. Unfortunately we had node-scheduler.include-coordinator set to true in all the tests so it was not catch by automation. This commit adds a regression test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.