Increase event-listener.max-concurrent-query-completed-events to 1000#22994
Closed
sopel39 wants to merge 1 commit intotrinodb:masterfrom
Closed
Increase event-listener.max-concurrent-query-completed-events to 1000#22994sopel39 wants to merge 1 commit intotrinodb:masterfrom
sopel39 wants to merge 1 commit intotrinodb:masterfrom
Conversation
wendigo
approved these changes
Aug 9, 2024
Member
|
We should revert the original PR. Trino should not drop events by default. That is a decision for the individual event listeners. |
Member
Author
|
We could maybe block instead of drop, so events don't grow unbounded and hurt coordinator stability. Although it's not easy with current code, so I'm not really sure how this can be done. I don't have cycles to work on this though. |
Member
Author
|
We should leave "concurrent" metric though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.